Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Auto refreshing on change tabs #5197

Closed
2 tasks done
pingsutw opened this issue Apr 7, 2024 · 6 comments · Fixed by #5229
Closed
2 tasks done

[BUG] Auto refreshing on change tabs #5197

pingsutw opened this issue Apr 7, 2024 · 6 comments · Fixed by #5229
Labels
backlogged For internal use. Reserved for contributor team workflow. bug Something isn't working

Comments

@pingsutw
Copy link
Member

pingsutw commented Apr 7, 2024

Describe the bug

Flyte docs keeps auto-refreshing when switching tab

Expected behavior

should not auto refresh

Additional context to reproduce

No response

Screenshots

Screen.Recording.2024-04-07.at.2.40.54.AM.mov

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@pingsutw pingsutw added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Apr 7, 2024
@kumare3
Copy link
Contributor

kumare3 commented Apr 8, 2024

I agree this is the left side bar- does not maintain position

@wild-endeavor wild-endeavor added backlogged For internal use. Reserved for contributor team workflow. and removed untriaged This issues has not yet been looked at by the Maintainers labels Apr 11, 2024
@MortalHappiness
Copy link
Member

https://github.com/pydata/pydata-sphinx-theme/blob/733d9f3264020c8a5bd3dde38f3ee3e5cdb2979a/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js#L133-L175
This theme uses sessionStorage to preserve the state of scrollbar position. We can reference it.

@pingsutw
Copy link
Member Author

cc @cosmicBboy Do you know how to fix it?

@cosmicBboy
Copy link
Contributor

@cosmicBboy
Copy link
Contributor

This is combined with some custom JS to scroll to the currently active heading in the toctree, which results in the contents sidebar scrolling with the user as they go.

Seems like this part isn't working

@cosmicBboy
Copy link
Contributor

@pingsutw see #5229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlogged For internal use. Reserved for contributor team workflow. bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants