update scroll behavior so that sidebar maintains location #5229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cosmicBboy <[email protected]>
dosubot
bot
added
size:M
Signed-off-by: cosmicBboy <[email protected]>
2 tasks
|
docs ci issue is unrelated |
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
|
@pingsutw mind +1'ing again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Fixes #5197
Why are the changes needed?
Currently in the docs the sidebar location is lost whenever you navigate to a new page. See #5197 for details.
What changes were proposed in this pull request?
Add custom javascript logic so that the sidebar location is maintained when you navigate across pages.
How was this patch tested?
Running
make docslocally.Screenshots
Check all the applicable boxes