Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monorepo] - Step 1 - Import golang repos #3881

Closed
wants to merge 1,948 commits into from

Conversation

eapolinario
Copy link
Contributor

Describe your changes

This PR is the first step in the consolidation of the Flyte components into a monorepo.

In this PR we only import the code for the golang components via git subtrees. By using git subtrees, as opposed to simply cherry-picking commits, we allow for code spelunking while maintaining the tooling simple (i.e. no need for git submodules).

pmahindrakar-oss and others added 30 commits November 10, 2022 15:41
* Adding configurable audience property for flyte clients

Signed-off-by: pmahindrakar-oss <[email protected]>

* gen

Signed-off-by: pmahindrakar-oss <[email protected]>

Signed-off-by: pmahindrakar-oss <[email protected]>
* disable codecov

Signed-off-by: Dan Rammer <[email protected]>

* bump codecov action verison

Signed-off-by: Dan Rammer <[email protected]>

Signed-off-by: Dan Rammer <[email protected]>
* Implemented SkipCache handling for execution config

Signed-off-by: Nick Müller <[email protected]>

* Added cache skip override to RelaunchExecution endpoint

Signed-off-by: Nick Müller <[email protected]>

* Updated to latest version of flytepropeller

Signed-off-by: Nick Müller <[email protected]>

* Renamed SkipCache flag to OverwriteCache
Updated to latest released versions of flyteidl, flyteplugins and flytestdlib
Updated to latest unmerged version of flytepropeller

Signed-off-by: Nick Müller <[email protected]>

* Updated flyteidl, flytepropeller and flytestdlib to latest released versions

Signed-off-by: Nick Müller <[email protected]>

* Reworded comment for clarity

Signed-off-by: Nick Müller <[email protected]>

Signed-off-by: Nick Müller <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>

Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
eapolinario and others added 27 commits July 7, 2023 07:36
* added ImagePullBackoffGracePeriod configuration

Signed-off-by: Daniel Rammer <[email protected]>

* fixed unit tests

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: eduardo apolinario <[email protected]>
Co-authored-by: eduardo apolinario <[email protected]>
Signed-off-by: eduardo apolinario <[email protected]>
Co-authored-by: eduardo apolinario <[email protected]>
* Implement Etag() in storage layer

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* go mod tidy

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Actually propagating etag

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Implement UnionMeta store

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Allow registeration of additional stow stores

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Support grpc NotFound in IsNotFound()

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* correct error code check

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Cleanup

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* more cleanup

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* PR Feedback

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* lint and nits

Signed-off-by: Yee Hing Tong <[email protected]>

---------

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Co-authored-by: Yee Hing Tong <[email protected]>
* Alter ID sequence to bigint

Signed-off-by: Hongxin Liang <[email protected]>

* Unit test it

Signed-off-by: Hongxin Liang <[email protected]>

---------

Signed-off-by: Hongxin Liang <[email protected]>
Signed-off-by: Flyte-Bot <[email protected]>
Co-authored-by: eapolinario <[email protected]>
…372)

* Refactor task log templates to support extra vars

* plumbing for k8s

* Cleanup use of providers

* cleanup

* more cleanups

* more cleanups

* more cleanups

* Plumb through task context for plugins

* fix

Signed-off-by: Jeev B <[email protected]>

* move task execution identifier into Input struct

* use pointer

* tests

Signed-off-by: Jeev B <[email protected]>

* fix linting

Signed-off-by: Jeev B <[email protected]>

* cleanups

* fix

* revert to using regex replacements for performance

* Readd benchmark

* Split templating scheme (#373)

* Use a split templating scheme

* add enum for TemplateScheme

* cleanup comment

* fix linting issues

* add unit tests for templateVarsForScheme

* update for consistency

---------

Signed-off-by: Jeev B <[email protected]>
Signed-off-by: Flyte-Bot <[email protected]>
Co-authored-by: eapolinario <[email protected]>
Signed-off-by: Flyte-Bot <[email protected]>
Co-authored-by: eapolinario <[email protected]>
Signed-off-by: Flyte-Bot <[email protected]>
Co-authored-by: eapolinario <[email protected]>
* Fix generate check in CI

* Re-run `make generate`
Signed-off-by: eduardo apolinario <[email protected]>
Co-authored-by: eduardo apolinario <[email protected]>
Signed-off-by: eduardo apolinario <[email protected]>
Co-authored-by: eduardo apolinario <[email protected]>
Previously, the hash set on an input literal would be ignored if
the literal was of either the `Collection` or `Map` type. This is
fixed here by moving the hash-checking branch up in front of the
special type logic, so that an empty literal with hash is constructed
in either case if a hash is found.

Adds a regression test to verify the hashes are carried over into the
representer literals for both map and collection types.

Signed-off-by: Nicholas Junge <[email protected]>
git-subtree-dir: flyteadmin
git-subtree-mainline: 845d0f5
git-subtree-split: 248e947
…e4a2ee'

git-subtree-dir: flytepropeller
git-subtree-mainline: ec30f0d
git-subtree-split: 4322012
…237'

git-subtree-dir: flytestdlib
git-subtree-mainline: 5ce1b0f
git-subtree-split: e088ca6
…7e6a'

git-subtree-dir: flyteplugins
git-subtree-mainline: f952072
git-subtree-split: 3405f89
…da1f'

git-subtree-dir: flytecopilot
git-subtree-mainline: 4e28e72
git-subtree-split: 5a38c21
…087'

git-subtree-dir: datacatalog
git-subtree-mainline: 6405e0f
git-subtree-split: 6923ab8
Signed-off-by: eduardo apolinario <[email protected]>
@eapolinario
Copy link
Contributor Author

Redone in #4012.

@eapolinario eapolinario closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.