Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo build images #4027

Merged

Conversation

eapolinario
Copy link
Contributor

@eapolinario eapolinario commented Sep 12, 2023

Describe your changes

This is a stacked PR on top of #4014 where we enable:

@eapolinario eapolinario force-pushed the monorepo--build-images branch from 5392133 to 35df30f Compare September 12, 2023 20:20
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario eapolinario force-pushed the monorepo--build-images branch from 6b278b3 to 272321a Compare September 13, 2023 06:32
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (monorepo--rename-modules-and-go-replace@b55f27b). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head a504b9b differs from pull request most recent head c6ac977. Consider uploading reports for the commit c6ac977 to get more accurate results

Additional details and impacted files
@@                            Coverage Diff                             @@
##             monorepo--rename-modules-and-go-replace    #4027   +/-   ##
==========================================================================
  Coverage                                           ?   58.07%           
==========================================================================
  Files                                              ?       34           
  Lines                                              ?     1784           
  Branches                                           ?        0           
==========================================================================
  Hits                                               ?     1036           
  Misses                                             ?      657           
  Partials                                           ?       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario and others added 2 commits September 13, 2023 13:01
Signed-off-by: Eduardo Apolinario <[email protected]>
* Fix flyteplugins lint errors

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix datacatalog lint errors

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flyteadmin lint errors

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flyteaidl lint errors

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flytepropeller lint errors

Signed-off-by: Eduardo Apolinario <[email protected]>

* Comment flytecopilot lint and flyteidl unit tests

Signed-off-by: Eduardo Apolinario <[email protected]>

---------

Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
@eapolinario eapolinario merged commit 2d0bbc4 into monorepo--rename-modules-and-go-replace Sep 13, 2023
38 of 39 checks passed
@eapolinario eapolinario deleted the monorepo--build-images branch September 13, 2023 21:44
eapolinario added a commit that referenced this pull request Sep 13, 2023
* Add dockerfiles

Signed-off-by: Eduardo Apolinario <[email protected]>

* Build component using reusable workflow

Signed-off-by: Eduardo Apolinario <[email protected]>

* Add "Components checks" workflow

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix typo

Signed-off-by: Eduardo Apolinario <[email protected]>

* Rename gh workflow

Signed-off-by: Eduardo Apolinario <[email protected]>

* Use the correct dockerfile

Signed-off-by: Eduardo Apolinario <[email protected]>

* Enable endtoend tests

Signed-off-by: Eduardo Apolinario <[email protected]>

* Use correct path to end2end reusable workflow

Signed-off-by: Eduardo Apolinario <[email protected]>

* Use unique prefixes for the cache

Signed-off-by: Eduardo Apolinario <[email protected]>

* Use tmp/tmp

Signed-off-by: Eduardo Apolinario <[email protected]>

* Be more explicit about the path components docker images are saved to

Signed-off-by: Eduardo Apolinario <[email protected]>

* Test only overriding datacatalog image

Signed-off-by: Eduardo Apolinario <[email protected]>

* Comment out actual helm upgrades (i.e. simply run tests)

Signed-off-by: Eduardo Apolinario <[email protected]>

* Comment out end2end and bring integration tests

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix typo in definition of priorities

Signed-off-by: Eduardo Apolinario <[email protected]>

* Hardcode go version to 1.19

Signed-off-by: Eduardo Apolinario <[email protected]>

* Use correct working directory in integration.yml

Signed-off-by: Eduardo Apolinario <[email protected]>

* Enable flytepropeller integration tests

Signed-off-by: Eduardo Apolinario <[email protected]>

* Unpack envvars prior to calling reusable workflow

Signed-off-by: Eduardo Apolinario <[email protected]>

* Enable go_generate.yml

Signed-off-by: Eduardo Apolinario <[email protected]>

* Enable push_docker_image

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flytecopilot go generate

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix image tags

Signed-off-by: Eduardo Apolinario <[email protected]>

* Enable lint and unit tests

Signed-off-by: Eduardo Apolinario <[email protected]>

* Pass component to lint and unit-tests jobs

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flytestdlib unit test

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flyteplugins test

Signed-off-by: Eduardo Apolinario <[email protected]>

* Build flytescheduler image

Signed-off-by: Eduardo Apolinario <[email protected]>

* Monorepo  ci checks fix lint (#4032)

* Fix flyteplugins lint errors

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix datacatalog lint errors

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flyteadmin lint errors

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flyteaidl lint errors

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flytepropeller lint errors

Signed-off-by: Eduardo Apolinario <[email protected]>

* Comment flytecopilot lint and flyteidl unit tests

Signed-off-by: Eduardo Apolinario <[email protected]>

---------

Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>

---------

Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario added a commit that referenced this pull request Sep 25, 2023
* Add go replace directives

Signed-off-by: Eduardo Apolinario <[email protected]>

* Rename modules and add go replace directives

Signed-off-by: Eduardo Apolinario <[email protected]>

* Rename imports in datacatalog

Signed-off-by: Eduardo Apolinario <[email protected]>

* Rename imports in flyteadmin

Signed-off-by: Eduardo Apolinario <[email protected]>

* Rename imports in flytecopilot

Signed-off-by: Eduardo Apolinario <[email protected]>

* Rename imports in flyteplugins

Signed-off-by: Eduardo Apolinario <[email protected]>

* Rename imports in flytepropeller

Signed-off-by: Eduardo Apolinario <[email protected]>

* Rename imports in flytestdlib

Signed-off-by: Eduardo Apolinario <[email protected]>

* Import flyteidl and add necessary go replace directives

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flytecopilot references

Signed-off-by: Eduardo Apolinario <[email protected]>

* Run make helm

Signed-off-by: Eduardo Apolinario <[email protected]>

* Monorepo  build images (#4027)

* Add dockerfiles

Signed-off-by: Eduardo Apolinario <[email protected]>

* Build component using reusable workflow

Signed-off-by: Eduardo Apolinario <[email protected]>

* Add "Components checks" workflow

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix typo

Signed-off-by: Eduardo Apolinario <[email protected]>

* Rename gh workflow

Signed-off-by: Eduardo Apolinario <[email protected]>

* Use the correct dockerfile

Signed-off-by: Eduardo Apolinario <[email protected]>

* Enable endtoend tests

Signed-off-by: Eduardo Apolinario <[email protected]>

* Use correct path to end2end reusable workflow

Signed-off-by: Eduardo Apolinario <[email protected]>

* Use unique prefixes for the cache

Signed-off-by: Eduardo Apolinario <[email protected]>

* Use tmp/tmp

Signed-off-by: Eduardo Apolinario <[email protected]>

* Be more explicit about the path components docker images are saved to

Signed-off-by: Eduardo Apolinario <[email protected]>

* Test only overriding datacatalog image

Signed-off-by: Eduardo Apolinario <[email protected]>

* Comment out actual helm upgrades (i.e. simply run tests)

Signed-off-by: Eduardo Apolinario <[email protected]>

* Comment out end2end and bring integration tests

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix typo in definition of priorities

Signed-off-by: Eduardo Apolinario <[email protected]>

* Hardcode go version to 1.19

Signed-off-by: Eduardo Apolinario <[email protected]>

* Use correct working directory in integration.yml

Signed-off-by: Eduardo Apolinario <[email protected]>

* Enable flytepropeller integration tests

Signed-off-by: Eduardo Apolinario <[email protected]>

* Unpack envvars prior to calling reusable workflow

Signed-off-by: Eduardo Apolinario <[email protected]>

* Enable go_generate.yml

Signed-off-by: Eduardo Apolinario <[email protected]>

* Enable push_docker_image

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flytecopilot go generate

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix image tags

Signed-off-by: Eduardo Apolinario <[email protected]>

* Enable lint and unit tests

Signed-off-by: Eduardo Apolinario <[email protected]>

* Pass component to lint and unit-tests jobs

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flytestdlib unit test

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flyteplugins test

Signed-off-by: Eduardo Apolinario <[email protected]>

* Build flytescheduler image

Signed-off-by: Eduardo Apolinario <[email protected]>

* Monorepo  ci checks fix lint (#4032)

* Fix flyteplugins lint errors

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix datacatalog lint errors

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flyteadmin lint errors

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flyteaidl lint errors

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flytepropeller lint errors

Signed-off-by: Eduardo Apolinario <[email protected]>

* Comment flytecopilot lint and flyteidl unit tests

Signed-off-by: Eduardo Apolinario <[email protected]>

---------

Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>

---------

Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>

* [Monorepo] - Fix single binary (#4015)

* Fix single-binary

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flyteplugins references in single-binary

Signed-off-by: Eduardo Apolinario <[email protected]>

* Point to local flyteidl in single-binary

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flytecopilot references

Signed-off-by: Eduardo Apolinario <[email protected]>

---------

Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>

* Run make generate in flytepropeller

Signed-off-by: Eduardo Apolinario <[email protected]>

* Build sandbox-lite using monorepo

Signed-off-by: Eduardo Apolinario <[email protected]>

* Comment out push_docker_image step

Signed-off-by: Eduardo Apolinario <[email protected]>

---------

Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant