Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inputs outputs wrapper #4298

Open
wants to merge 40 commits into
base: master
Choose a base branch
from

Fix make generate and run it

ddc3fe0
Select commit
Loading
Failed to load commit list.
Open

Inputs outputs wrapper #4298

Fix make generate and run it
ddc3fe0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 4, 2024 in 0s

62.24% (+1.32%) compared to f075b34

View this Pull Request on Codecov

62.24% (+1.32%) compared to f075b34

Details

Codecov Report

Attention: Patch coverage is 60.86957% with 90 lines in your changes missing coverage. Please review.

Project coverage is 62.24%. Comparing base (f075b34) to head (ddc3fe0).

Files Patch % Lines
flyteadmin/pkg/manager/impl/util/data.go 32.65% 28 Missing and 5 partials ⚠️
flyteadmin/pkg/manager/impl/execution_manager.go 70.51% 18 Missing and 5 partials ⚠️
...teadmin/pkg/repositories/transformers/execution.go 46.15% 12 Missing and 2 partials ⚠️
...pkg/manager/impl/validation/execution_validator.go 59.09% 7 Missing and 2 partials ⚠️
...in/pkg/repositories/transformers/node_execution.go 62.50% 2 Missing and 1 partial ⚠️
...in/pkg/repositories/transformers/task_execution.go 62.50% 2 Missing and 1 partial ⚠️
flyteadmin/pkg/common/data_store.go 66.66% 1 Missing and 1 partial ⚠️
...eadmin/pkg/async/schedule/aws/workflow_executor.go 92.30% 0 Missing and 1 partial ⚠️
...anager/impl/validation/node_execution_validator.go 80.00% 0 Missing and 1 partial ⚠️
...anager/impl/validation/task_execution_validator.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4298      +/-   ##
==========================================
+ Coverage   60.92%   62.24%   +1.32%     
==========================================
  Files         796      462     -334     
  Lines       51689    27849   -23840     
==========================================
- Hits        31494    17336   -14158     
+ Misses      17288     8949    -8339     
+ Partials     2907     1564    -1343

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov