Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ingressClassName in flyte-core #4551

Closed
wants to merge 4 commits into from
Closed

Add support for ingressClassName in flyte-core #4551

wants to merge 4 commits into from

Conversation

davidmirror-ops
Copy link
Contributor

@davidmirror-ops davidmirror-ops commented Dec 7, 2023

Why are the changes needed?

As the kubernetes.io/ingressClass annotation is deprecated since K8s 1.18, this PR adds support for the new mechanism (ingressClassName) to flyte-core.

This is useful in environments where there are multiple Ingress controllers running or, when cert-manager's ingress-shim is configured to generate SSL certificates for Ingress resources, using the ingressClassName as selector.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: davidmirror-ops <[email protected]>
Signed-off-by: davidmirror-ops <[email protected]>
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (91d24a9) 58.98% compared to head (e4f46d0) 58.98%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4551   +/-   ##
=======================================
  Coverage   58.98%   58.98%           
=======================================
  Files         621      621           
  Lines       52483    52483           
=======================================
+ Hits        30957    30958    +1     
+ Misses      19059    19058    -1     
  Partials     2467     2467           
Flag Coverage Δ
unittests 58.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: davidmirror-ops <[email protected]>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Dec 7, 2023
@eapolinario
Copy link
Contributor

Small typo in the description: it should say k8s 1.18 not 1.28, right?

On a related note, how can we determine what's the minimal supported version of k8s?

@davidmirror-ops
Copy link
Contributor Author

Small typo in the description: it should say k8s 1.18 not 1.28, right?

On a related note, how can we determine what's the minimal supported version of k8s?

Typo fixed.

Regarding upstream K8s version skew policy, it's basically n-2. For older versions, it's only time-limited patch support.

@davidmirror-ops davidmirror-ops closed this by deleting the head repository Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants