Update flyte-binary values #4604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: davidmirror-ops <[email protected]>
dosubot
bot
added
size:M
davidmirror-ops
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4604 +/- ##
==========================================
+ Coverage 59.03% 63.70% +4.67%
==========================================
Files 622 108 -514
Lines 52793 6543 -46250
==========================================
- Hits 31164 4168 -26996
+ Misses 19142 2107 -17035
+ Partials 2487 268 -2219
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: davidmirror-ops <[email protected]>
dosubot
bot
added
size:L
Signed-off-by: davidmirror-ops <[email protected]>
Signed-off-by: davidmirror-ops <[email protected]>
Signed-off-by: davidmirror-ops <[email protected]>
jeevb
reviewed
Dec 18, 2023
Signed-off-by: davidmirror-ops <[email protected]>
jeevb
reviewed
Dec 18, 2023
| @@ -1,35 +1,42 @@ | |||
| configuration: | |||
There was a problem hiding this comment.
Maybe we should just rename this eks-starter.yaml.
jeevb
previously approved these changes
Dec 18, 2023
Signed-off-by: davidmirror-ops <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Making the default values leaner, less opinionated, more informational and making sure they work OOB
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link