Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add FlytePlugins architecture image #4661

Merged
merged 13 commits into from
Jan 26, 2024

Conversation

jasonlai1218
Copy link
Contributor

@jasonlai1218 jasonlai1218 commented Jan 2, 2024

Docs link

https://flyte--4661.org.readthedocs.build/en/4661/concepts/component_architecture/flytepropeller_architecture.html

Why are the changes needed?

Let more people know the details of the interaction between Flyte Propeller and Flyte Plugins

What changes were proposed in this pull request?

  • Add an image of the FlytePlugins architecture to the end of the file

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

flyteorg/static-resources#34

Docs link

- Add an image of the FlytePlugins architecture to the end of the file

Signed-off-by: jason.lai <[email protected]>
Copy link

welcome bot commented Jan 2, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac5603b) 58.54% compared to head (f91139f) 58.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4661      +/-   ##
==========================================
- Coverage   58.54%   58.53%   -0.01%     
==========================================
  Files         625      625              
  Lines       53669    53669              
==========================================
- Hits        31418    31417       -1     
- Misses      19734    19735       +1     
  Partials     2517     2517              
Flag Coverage Δ
unittests 58.53% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Future-Outlier Future-Outlier marked this pull request as draft January 3, 2024 02:38
Future Outlier and others added 7 commits January 3, 2024 14:40
Signed-off-by: Future Outlier <[email protected]>
nit
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
… add-flyte-architecture

Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
@Future-Outlier
Copy link
Member

Future-Outlier commented Jan 21, 2024

We should merge this PR first.
flyteorg/static-resources#34

@Future-Outlier Future-Outlier self-assigned this Jan 21, 2024
@Future-Outlier Future-Outlier marked this pull request as ready for review January 21, 2024 04:54
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 21, 2024
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image
image

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 26, 2024
@Future-Outlier Future-Outlier enabled auto-merge (squash) January 26, 2024 09:10
@Future-Outlier Future-Outlier merged commit 3e9fb05 into flyteorg:master Jan 26, 2024
43 of 45 checks passed
Copy link

welcome bot commented Jan 26, 2024

Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants