Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artf/lineage and fixes #4680

Merged
merged 17 commits into from
Jan 9, 2024
Merged

Artf/lineage and fixes #4680

merged 17 commits into from
Jan 9, 2024

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Jan 5, 2024

  • Fix the execution start lineage tracking by adding the tracking tag
    • Update url parsing
    • Update execution manager to parse out tracking tags and send in event
    • rename the confusing artifact_keys to artifact_trackers
  • Pull in changes in master
    • remove inputs/outputs from cloud events

Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
…e we're no longer supporting that feature (yet), change the parsing logic to handle versions with slashes, update tests to match, update events handler to read the tracking tag and construct artifact IDs out of it, install tracking string into literal metadata that's just project/domain/name@version

Signed-off-by: Yee Hing Tong <[email protected]>
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request housekeeping Issues that help maintain flyte and keep it tech-debt free labels Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (7557d62) 58.14% compared to head (49d3f7d) 58.22%.
Report is 1 commits behind head on artifacts.

❗ Current head 49d3f7d differs from pull request most recent head d3f432d. Consider uploading reports for the commit d3f432d to get more accurate results

Files Patch % Lines
flyteadmin/pkg/manager/impl/execution_manager.go 24.00% 19 Missing ⚠️
...cloudevent/implementations/cloudevent_publisher.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           artifacts    #4680      +/-   ##
=============================================
+ Coverage      58.14%   58.22%   +0.08%     
=============================================
  Files            626      592      -34     
  Lines          53782    51607    -2175     
=============================================
- Hits           31273    30050    -1223     
+ Misses         20001    19148     -853     
+ Partials        2508     2409      -99     
Flag Coverage Δ
unittests 58.22% <23.07%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Jan 9, 2024
@wild-endeavor wild-endeavor merged commit de919c0 into artifacts Jan 9, 2024
21 of 25 checks passed
@wild-endeavor wild-endeavor deleted the artf/lineage-and-fixes branch January 9, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request housekeeping Issues that help maintain flyte and keep it tech-debt free size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant