Replace Storage To Ephemeral Storage in Helm Chart
#4782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Future-Outlier <[email protected]>
dosubot
bot
added
size:L
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4782 +/- ##
=======================================
Coverage 58.54% 58.54%
=======================================
Files 625 625
Lines 53669 53669
=======================================
Hits 31418 31418
Misses 19734 19734
Partials 2517 2517
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thank you @Future-Outlier! |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Fixes #3728
Why are the changes needed?
Make users will not request storage when using flyte.
What changes were proposed in this pull request?
replace
storagetoephemeralStoragein charts/flyte-core/values.yamlHow was this patch tested?
you can check the request name from flyteadmin here, that's why the key is
ephemeralStorage.https://github.com/flyteorg/flyte/blob/master/flyteadmin/pkg/runtime/interfaces/task_resource_configuration.go#L5-L11
Setup process
Screenshots
Check all the applicable boxes
Related PRs
flyteorg/flytekit#2078
Docs link