Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repeated items in left nav #4783

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Fix repeated items in left nav #4783

merged 1 commit into from
Jan 26, 2024

Conversation

ppiegaze
Copy link
Member

Why are the changes needed?

Left navigation had repeated items in it

What changes were proposed in this pull request?

Remove redundant items in left nav

How was this patch tested?

Local build of docs validated

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Signed-off-by: Peeter Piegaze <[email protected]>
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 26, 2024
@ppiegaze ppiegaze requested a review from neverett January 26, 2024 11:16
@dosubot dosubot bot added documentation Improvements or additions to documentation housekeeping Issues that help maintain flyte and keep it tech-debt free labels Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e9fb05) 58.53% compared to head (f7968e8) 58.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4783   +/-   ##
=======================================
  Coverage   58.53%   58.54%           
=======================================
  Files         625      625           
  Lines       53669    53669           
=======================================
+ Hits        31417    31418    +1     
+ Misses      19735    19734    -1     
  Partials     2517     2517           
Flag Coverage Δ
unittests 58.54% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppiegaze ppiegaze requested a review from samhita-alla January 26, 2024 11:23
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 26, 2024
@ppiegaze ppiegaze merged commit d728da6 into master Jan 26, 2024
45 checks passed
@ppiegaze ppiegaze deleted the docs/peeter/fix-left-nav branch January 26, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation housekeeping Issues that help maintain flyte and keep it tech-debt free lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants