Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add apache 2.0 license to python flyteidl #4786

Merged
merged 1 commit into from
Jan 30, 2024
Merged

feat: add apache 2.0 license to python flyteidl #4786

merged 1 commit into from
Jan 30, 2024

Conversation

michaeltinsley
Copy link
Contributor

Tracking issue

#4771

Close #4771

Why are the changes needed?

Currently the flyteidl Python library does not have a license specified in the metadata. Whilst the license is specified for the repository, specifying it for the library is useful for license checks.

What changes were proposed in this pull request?

Specify the license in the flyteidl setup.py

How was this patch tested?

N/A

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Jan 28, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (abef3f5) 58.54% compared to head (298fa8c) 58.54%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4786      +/-   ##
==========================================
- Coverage   58.54%   58.54%   -0.01%     
==========================================
  Files         625      625              
  Lines       53669    53669              
==========================================
- Hits        31423    31418       -5     
- Misses      19731    19734       +3     
- Partials     2515     2517       +2     
Flag Coverage Δ
unittests 58.54% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 30, 2024
@pingsutw pingsutw merged commit ffd3ab2 into flyteorg:master Jan 30, 2024
44 of 45 checks passed
@pingsutw
Copy link
Member

Thank you

@michaeltinsley michaeltinsley deleted the add-flyteidl-python-license branch February 1, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Housekeeping] Add a license to the Python flyteidl library
2 participants