Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update additional bindings for org in path to be consistent #4795

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

katrogan
Copy link
Contributor

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. housekeeping Issues that help maintain flyte and keep it tech-debt free labels Jan 30, 2024
Signed-off-by: Katrina Rogan <[email protected]>
@katrogan katrogan requested review from EngHabu and hamersaw January 30, 2024 19:48
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a7f6ff) 58.57% compared to head (dac1ed6) 58.57%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4795   +/-   ##
=======================================
  Coverage   58.57%   58.57%           
=======================================
  Files         624      624           
  Lines       53595    53595           
=======================================
+ Hits        31391    31393    +2     
+ Misses      19689    19688    -1     
+ Partials     2515     2514    -1     
Flag Coverage Δ
unittests 58.57% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 30, 2024
@katrogan katrogan requested a review from pingsutw January 30, 2024 21:17
@katrogan katrogan merged commit bce5d8c into master Jan 30, 2024
45 checks passed
@katrogan katrogan deleted the org-rewrite-fix branch January 30, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants