Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate idl #4796

Closed
wants to merge 2 commits into from
Closed

Regenerate idl #4796

wants to merge 2 commits into from

Conversation

eapolinario
Copy link
Contributor

Tracking issue

NA

Why are the changes needed?

We re-enabled the CI check to look for discrepancies in #4630, but idl changed since. This PR regenerates it. We'll set this as a required check after this lands.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <[email protected]>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. housekeeping Issues that help maintain flyte and keep it tech-debt free labels Jan 30, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bce5d8c) 59.02% compared to head (37422c6) 58.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4796      +/-   ##
==========================================
- Coverage   59.02%   58.52%   -0.50%     
==========================================
  Files         643      625      -18     
  Lines       55153    53638    -1515     
==========================================
- Hits        32552    31393    -1159     
+ Misses      20020    19729     -291     
+ Partials     2581     2516      -65     
Flag Coverage Δ
unittests 58.52% <ø> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant