Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use buf to generate stubs #4806

Merged
merged 45 commits into from
Feb 6, 2024
Merged

Use buf to generate stubs #4806

merged 45 commits into from
Feb 6, 2024

Conversation

eapolinario
Copy link
Contributor

Tracking issue

NA

Why are the changes needed?

What changes were proposed in this pull request?

Use buf to produce proto stubs, including stubs for typescript and buf connect.

We're not going to generate java and cpp anymore.

We'll have to figure out a way to serve the generated swagger.json file in admin (in a separate PR).

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

wild-endeavor and others added 15 commits January 25, 2024 15:48
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request housekeeping Issues that help maintain flyte and keep it tech-debt free labels Jan 31, 2024
@eapolinario eapolinario changed the title Use buf Use buf to generate stubs Jan 31, 2024
Signed-off-by: Eduardo Apolinario <[email protected]>
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bfe61f9) 58.97% compared to head (822d0b3) 58.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4806   +/-   ##
=======================================
  Coverage   58.97%   58.98%           
=======================================
  Files         644      645    +1     
  Lines       55146    55148    +2     
=======================================
+ Hits        32525    32529    +4     
+ Misses      20048    20045    -3     
- Partials     2573     2574    +1     
Flag Coverage Δ
unittests 58.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eapolinario and others added 8 commits January 31, 2024 15:39
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Feb 1, 2024
eapolinario and others added 17 commits February 1, 2024 00:17
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 6, 2024
@eapolinario eapolinario enabled auto-merge (squash) February 6, 2024 22:22
@eapolinario eapolinario merged commit 0132cba into master Feb 6, 2024
49 checks passed
@eapolinario eapolinario deleted the buf-experiment branch February 6, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request housekeeping Issues that help maintain flyte and keep it tech-debt free lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants