Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install latest flyteidl when building monodocs #4815

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Conversation

cosmicBboy
Copy link
Contributor

This PR updates the monodocs environment conda yaml file so that it installs the latest version of flyteidl in the flyte repo.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. documentation Improvements or additions to documentation labels Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d24d23) 58.98% compared to head (d03af6b) 58.97%.

❗ Current head d03af6b differs from pull request most recent head 8c8c231. Consider uploading reports for the commit 8c8c231 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4815      +/-   ##
==========================================
- Coverage   58.98%   58.97%   -0.02%     
==========================================
  Files         644      644              
  Lines       55145    55145              
==========================================
- Hits        32528    32521       -7     
- Misses      20043    20050       +7     
  Partials     2574     2574              
Flag Coverage Δ
unittests 58.97% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Niels Bantilan <[email protected]>
@cosmicBboy cosmicBboy enabled auto-merge (squash) February 1, 2024 16:07
@cosmicBboy cosmicBboy merged commit 94b47fd into master Feb 1, 2024
47 checks passed
@cosmicBboy cosmicBboy deleted the fix-docs-flyteidl branch February 1, 2024 16:16
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 1, 2024
@neverett neverett mentioned this pull request Feb 1, 2024
2 tasks
@Future-Outlier
Copy link
Member

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants