[BUG] Invalid "resources" scope in clusterresourcesync/deployment.yaml #4916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4916 +/- ##
=======================================
Coverage 58.97% 58.97%
=======================================
Files 645 645
Lines 55506 55559 +53
=======================================
+ Hits 32732 32765 +33
- Misses 20174 20198 +24
+ Partials 2600 2596 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
lowc1012
force-pushed
the
flyte-issue-4915
branch
from
86e3a54 to
f406f4b
Compare
|
Verified that |
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
flyteorg#4916) * fix invalid clusterresourcesync/deployment.yaml Signed-off-by: Ryan Lo <[email protected]> * update README.md Signed-off-by: Ryan Lo <[email protected]> * update generated yaml files Signed-off-by: Ryan Lo <[email protected]> * fix typo Signed-off-by: Ryan Lo <[email protected]> --------- Signed-off-by: Ryan Lo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #4915
Why are the changes needed?
fix a bug in clusterresourcesync/deployment.yaml when users identify resources
What changes were proposed in this pull request?
resources: {}into charts/flyte-core/values.yaml as default valuewithto render resources for deployment if the .Values.cluster_resource_manager.resources is not empty.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link