Specify builder for docker build #5002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5002 +/- ##
==========================================
- Coverage 58.97% 58.95% -0.03%
==========================================
Files 645 645
Lines 55562 55562
==========================================
- Hits 32767 32754 -13
- Misses 20200 20212 +12
- Partials 2595 2596 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
docker/sandbox-bundled/Makefile
Outdated
| --driver docker-container --driver-opt image=moby/buildkit:master \ | ||
| --buildkitd-flags '--allow-insecure-entitlement security.insecure' \ | ||
| --platform linux/arm64,linux/amd64 | ||
| build: create_builder flyte dep_update manifests |
There was a problem hiding this comment.
Need some tiny change, cause create_builder will be called in flyte
There was a problem hiding this comment.
Should we remove repetitive called?
Signed-off-by: Kevin Su <[email protected]>
dosubot
bot
added
lgtm
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
* Specify builder for docker build Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Failed to build the sandbox-bundled
What changes were proposed in this pull request?
Specify builder for docker build
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link