Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plugins support for k8s imagepullpolicy #5167

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

novahow
Copy link
Contributor

@novahow novahow commented Apr 3, 2024

Tracking issue

https://github.com/flyteorg/flyte/issues/

Why are the changes needed?

Users should be able to configure the ImagePullPolicy they desire for created pods in k8s plugin.

What changes were proposed in this pull request?

Added a field ImagePullPolicy in flytek8s plugin.

How was this patch tested?

make test_unit

setting different values for image-pull-policy, including not specifying the value (i.e. no image-pull-policy key)

plugins:
  logs:
    kubernetes-enabled: true
    kubernetes-template-uri: http://localhost:30080/kubernetes-dashboard/#/log/{{.namespace }}/{{ .podName }}/pod?namespace={{ .namespace }}
    cloudwatch-enabled: false
    stackdriver-enabled: false
  k8s:
    image-pull-policy: Always
    default-env-vars:
      - FLYTE_AWS_ENDPOINT: http://flyte-sandbox-minio.flyte:9000
      - FLYTE_AWS_ACCESS_KEY_ID: minio
      - FLYTE_AWS_SECRET_ACCESS_KEY: miniostorage
  k8s-array:
    logs:
      config:
        kubernetes-enabled: true
        kubernetes-template-uri: http://localhost:30080/kubernetes-dashboard/#/log/{{.namespace }}/{{ .podName }}/pod?namespace={{ .namespace }}
        cloudwatch-enabled: false
        stackdriver-enabled: false

Not specified
image
IfNotPresent
image
Always
image
Never
image

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation enhancement New feature or request labels Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.11%. Comparing base (524b473) to head (ee3f1c2).
Report is 21 commits behind head on master.

❗ Current head ee3f1c2 differs from pull request most recent head c014394. Consider uploading reports for the commit c014394 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5167      +/-   ##
==========================================
+ Coverage   59.10%   59.11%   +0.01%     
==========================================
  Files         645      645              
  Lines       55574    55575       +1     
==========================================
+ Hits        32846    32853       +7     
+ Misses      20135    20129       -6     
  Partials     2593     2593              
Flag Coverage Δ
unittests 59.11% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: novahow <[email protected]>
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 7, 2024
@pingsutw pingsutw merged commit 3004af4 into flyteorg:master Apr 15, 2024
46 checks passed
@novahow novahow deleted the plugin/configure_imagepull branch April 17, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants