Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cache client read and write otel tracing #5184

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Conversation

pvditt
Copy link
Contributor

@pvditt pvditt commented Apr 5, 2024

Tracking issue

https://github.com/flyteorg/flyte/issues/

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.09%. Comparing base (24a6e4e) to head (9263d71).
Report is 9 commits behind head on master.

❗ Current head 9263d71 differs from pull request most recent head 889b8e2. Consider uploading reports for the commit 889b8e2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5184      +/-   ##
==========================================
+ Coverage   58.88%   59.09%   +0.21%     
==========================================
  Files         568      646      +78     
  Lines       47967    55744    +7777     
==========================================
+ Hits        28243    32940    +4697     
- Misses      17309    20208    +2899     
- Partials     2415     2596     +181     
Flag Coverage Δ
unittests 59.09% <100.00%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pvditt pvditt requested a review from hamersaw April 8, 2024 18:26
@pvditt pvditt marked this pull request as ready for review April 8, 2024 18:26
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Apr 8, 2024
Signed-off-by: Paul Dittamo <[email protected]>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 8, 2024
@pvditt pvditt merged commit 2528de7 into master Apr 8, 2024
46 checks passed
@pvditt pvditt deleted the add-otel-cache-trace branch April 8, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants