Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize flyteidl Rust crate #5219

Merged
merged 4 commits into from
Apr 21, 2024

Conversation

austin362667
Copy link
Contributor

Tracking issue

flyteorg/flytekit#2328

Why are the changes needed?

Expose Flyteidl Rust crate based on #5187

It can be added as a local dependency by Flyekit.

What changes were proposed in this pull request?

Initialize cargo.toml and lib.rs.

How was this patch tested?

Setup process

cargo b --release

Screenshots

Screenshot 2024-04-11 at 6 59 43 PM

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Austin Liu <[email protected]>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Apr 11, 2024
Signed-off-by: Austin Liu <[email protected]>
@kumare3
Copy link
Contributor

kumare3 commented Apr 14, 2024

Will we build a rust client crate here?

@austin362667
Copy link
Contributor Author

I don't think so for now.
We just need to expose flyteidl as a Rust Crate in advance. So it can be added as dependency for underlying Rust client.

@austin362667
Copy link
Contributor Author

austin362667 commented Apr 14, 2024

pingsutw
pingsutw previously approved these changes Apr 15, 2024
flyteidl/lib.rs Outdated Show resolved Hide resolved
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 15, 2024
Signed-off-by: Austin Liu <[email protected]>
@pingsutw pingsutw merged commit c64b5e3 into flyteorg:master Apr 21, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants