Flyte core webhook pod settings should be separate #5490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previously, the webhook was sharing some pod level settings in the core chart with flytepropeller like: * podAnnotations * podEnv * podLabels * nodeSelector Since the webhook runs a separate pod, it should have separate settings NOTE: no attempt is made to honor carrying over any previous settings from flytepropeller values to webhook values, but given these were recently introduced / fixed in January as part of flyteorg#4756, I think they're not used very much Signed-off-by: ddl-ebrown <[email protected]>
ddl-ebrown
force-pushed
the
separate-chart-webhook-values
branch
from
6afcb1b to
bf7177d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5490 +/- ##
=======================================
Coverage 61.01% 61.01%
=======================================
Files 793 793
Lines 51422 51422
=======================================
Hits 31376 31376
Misses 17154 17154
Partials 2892 2892
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Jun 22, 2024
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
Signed-off-by: ddl-ebrown <[email protected]>
vlibov
pushed a commit
to vlibov/flyte
that referenced
this pull request
Aug 16, 2024
Signed-off-by: ddl-ebrown <[email protected]> Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Previously, the webhook was sharing some pod level settings in the core chart with flytepropeller like:
Since the webhook runs a separate pod, it should have separate
settings. This allows for independently adding annotations, like for configuring Prometheus. propeller has a /metrics endpoint, while webhook does not.
NOTE: this isn't backwards compatible, but I also think it's a fairly minor issue that can be covered in docs. I suspect there aren't currently many users here and some of these were not introduced not long ago (as part of #4756)
What changes were proposed in this pull request?
Moves webhook level settings to their own section
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link