Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Union type with dataclass ambiguous error and support superset comparison #5858

Merged
merged 30 commits into from
Nov 20, 2024

fix: change test name and fix err

9b19f04
Select commit
Loading
Failed to load commit list.
Merged

Fix Union type with dataclass ambiguous error and support superset comparison #5858

fix: change test name and fix err
9b19f04
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Nov 19, 2024 in 1s

72.34% of diff hit (target 37.14%)

View this Pull Request on Codecov

72.34% of diff hit (target 37.14%)

Annotations

Check warning on line 37 in flytepropeller/pkg/compiler/validators/typing.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/typing.go#L36-L37 

Added lines #L36 - L37 were not covered by tests

Check warning on line 41 in flytepropeller/pkg/compiler/validators/typing.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/typing.go#L40-L41 

Added lines #L40 - L41 were not covered by tests

Check warning on line 53 in flytepropeller/pkg/compiler/validators/typing.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/typing.go#L51-L53 

Added lines #L51 - L53 were not covered by tests

Check warning on line 66 in flytepropeller/pkg/compiler/validators/typing.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/typing.go#L65-L66 

Added lines #L65 - L66 were not covered by tests
View more details on Codecov