Fix flytestdlib's stowStore.List for google cloud storage #6098
+17
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Graetz <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6098 +/- ##
=======================================
Coverage 37.10% 37.10%
=======================================
Files 1318 1318
Lines 132403 132413 +10
=======================================
+ Hits 49122 49132 +10
- Misses 79008 79009 +1
+ Partials 4273 4272 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
For RFC #5598, flytepropeller was given the ability to list error files in the so-called raw output prefix bucket of an execution with the goal of identifying which worker pod in a failed distributed task experienced the first error.
For this purpose, the
StowStorein flytestdlib was given aListfunction.For google cloud storage buckets, the listing and subsequent access of the error files currently does not work: When listing a bucket
gs://some-bucket/..., one receives items in the formgoogle://storage.googleapis.com/download/storage/v1/b/some-bucket/...which then cannot be found by the stow store for thegs://prefix.This PR fixes this.
What changes were proposed in this pull request?
Don't use
item.URL()but construct the url from the protocol, the container name (bucket name), and the item name.How was this patch tested?
Tested in a GCP deployment and adapted unit test.
Related PRs