Rename external plugin to agent #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
pingsutw
requested review from
wild-endeavor,
kumare3,
eapolinario and
cosmicBboy
as code owners
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1666 +/- ##
=======================================
Coverage 71.02% 71.03%
=======================================
Files 336 336
Lines 30786 30793 +7
Branches 5587 5588 +1
=======================================
+ Hits 21867 21874 +7
+ Misses 8373 8364 -9
- Partials 546 555 +9
|
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Yee Hing Tong <[email protected]>
wild-endeavor
previously approved these changes
May 31, 2023
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
eapolinario
reviewed
Jun 7, 2023
.github/workflows/pythonpublish.yml
Outdated
| @@ -161,12 +161,12 @@ jobs: | |||
| registry: ghcr.io | |||
| username: "${{ secrets.FLYTE_BOT_USERNAME }}" | |||
| password: "${{ secrets.FLYTE_BOT_PAT }}" | |||
| - name: Prepare External Plugin Service Image Names | |||
| id: external-plugin-service-names | |||
| - name: Prepare Fylte Agent Image Names | |||
setup.py
Outdated
| @@ -29,7 +29,7 @@ | |||
| }, | |||
| install_requires=[ | |||
| "googleapis-common-protos>=1.57", | |||
| "flyteidl>=1.5.6", | |||
| "flyteidl>1.5.6", | |||
There was a problem hiding this comment.
this should be flyteidl>=1.5.9, no?
There was a problem hiding this comment.
bumped version to 1.5.10. we yanked 1.5.9
Signed-off-by: Kevin Su <[email protected]>
eapolinario
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
as title
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA