Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array node serialize with corresponding plugin custom. #2014

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chaohengstudent
Copy link
Contributor

Tracking issue

Closes flyteorg/flyte#4515

Why are the changes needed?

Have to get the corresponding custom to operate plugins with array node map task.

What changes were proposed in this pull request?

Inherit func get_custom() with python_function_task in array_node_map_task.py

How was this patch tested?

Testing kftensorflow with array node in sandbox.
image

Screenshots

image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Chao-Heng Lee <[email protected]>
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a34ab93) 86.14% compared to head (fe47974) 54.61%.

Files Patch % Lines
flytekit/core/array_node_map_task.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2014       +/-   ##
===========================================
- Coverage   86.14%   54.61%   -31.54%     
===========================================
  Files         320      173      -147     
  Lines       23441    16770     -6671     
  Branches     3458     3458               
===========================================
- Hits        20194     9159    -11035     
- Misses       2655     7201     +4546     
+ Partials      592      410      -182     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw self-assigned this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Failed with running tensorflow plugin in array node map task.
2 participants