Skip to content
This repository has been archived by the owner on Sep 23, 2021. It is now read-only.

Linking references #82

Merged
merged 4 commits into from
Jan 3, 2019
Merged

Linking references #82

merged 4 commits into from
Jan 3, 2019

Conversation

CamposErik
Copy link
Contributor

@CamposErik CamposErik commented Jan 3, 2019

Changes description

Fix the gradle problems to include properly the library.

Checklist

Please check if your PR fulfills the following specifications:

  • Tests for the changes have been added
  • Docs have been added/updated

Estimated time

Assignee 🍅
@CamposErik 5

References

Closes #79
Related #79
Depends on #N/A

@ghost
Copy link

ghost commented Jan 3, 2019

There were the following issues with this Pull Request

  • Commit: 4364817
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@CamposErik CamposErik requested a review from ajsb85 January 3, 2019 09:59
@CamposErik CamposErik self-assigned this Jan 3, 2019
@CamposErik CamposErik added the bug label Jan 3, 2019
@CamposErik CamposErik added this to the 1.0 milestone Jan 3, 2019
@ghost
Copy link

ghost commented Jan 3, 2019

There were the following issues with this Pull Request

  • Commit: 4364817
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Jan 3, 2019

There were the following issues with this Pull Request

  • Commit: 4364817
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@CamposErik
Copy link
Contributor Author

@ajsb85 , this PR is finished, it needs to squash de wip commit with the others or delete the commit.

@ajsb85
Copy link
Contributor

ajsb85 commented Jan 3, 2019

Hi, @CamposErik
When the PR is ready to review please remove the WIP prefix.
The refactor commit type message is for source code not for build scripts.
And also you forgot to sign off your commits.

@ajsb85 ajsb85 merged commit ea9395f into develop Jan 3, 2019
@ajsb85 ajsb85 deleted the feature/fix-linking-references branch January 3, 2019 19:50
@ajsb85 ajsb85 changed the title WIP Linking references Linking references Jan 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed linking references
2 participants