[Features] Marketboard item caching + Universalis fetching data prompt + Recent history option #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pythyu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes (#70 and #69) :
Added an item buffer that allows to save the last N(by default 10) items fetched from the Universalis API. If the API shutdowns, these saved items should still be accessible.
The buffer is not saved between each game restart, the main benefits are that it reduces the number of request on the Universalis API when the same items are checked multiple times, and that if the Universalis API disconnect while playing the user can still look at their last searches.
Each item of this buffer will get re-fetched after a certain timeout by default 30 seconds. This setting can also be modified :
A prompt is added when new data is fetched :
The last time an item has been fetched is also displayed :
Bonus feature ([Feature Request] Disable "Recent History", make separation between "Current Listings" and "Recent History" adjustable #63) :
