Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IWXXM 2023-1 serialization support for AIRMETs and SIGMETs #121

Merged

Conversation

kasarit
Copy link
Contributor

@kasarit kasarit commented Oct 19, 2023

This PR adds IWXXM 2023-1 serialization support for AIRMETs and SIGMETs.

  • There are no functional changes to serializing older IWXXM versions and the support for 3.0 airmets and sigmets is kept in. I created a followup issue to remove it: Remove IWXXM 3.0 AIRMET/SIGMET serialization #122.
  • The 2023-1 serialization code is mostly the same as the 3.0 code. This PR does not address any potential issues in it. It only makes it compatible with 2023-1.
  • A significant source of annoyance is that IWXXM 2023-1 depends on the full AIXM 5.1.1 schema and 3.0 and 2.1.1 depend on the AIXM 5.1.1 WX schema. Both of these schemas use the same namespace for historical reasons. For more information, see: [question] aixm dependency - incoherencies wmo-im/iwxxm#277
    • Having two classes have the same XML type name does not work in the same JAXBContext. This necessitates splitting the JAXBContext into two where one of the contexts supports IWXXM 3.0 and older versions and the other IWXXM 2023-1. In this PR there's a fair amount of changes just to address this change and also duplicated code where the only difference is which package the classes are coming from. I created a followup issue to investigate whether there is a better solution to this: Investigate whether there is a better solution for handling AIXM 5.1.1 WX and AIXM 5.1.1 full schemas #123
  • All of the airmet/sigmet 3.0 serialization tests have been copied for 2023-1. There are no changes to the json source files for any of these tests.

Some actual differences between 3.0 and 2023-1 sigmets/airmets:

@kasarit kasarit linked an issue Oct 19, 2023 that may be closed by this pull request
@kasarit kasarit merged commit 2fe74be into main Oct 23, 2023
@kasarit kasarit deleted the 120-add-iwxxm-2023-1-serialization-support-for-airmetsigmet branch October 23, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IWXXM 2023-1 serialization support for AIRMET/SIGMET
1 participant