Added workaround for old xcode compiler bug #3716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…und for old xcode bugs
vitaut
requested changes
Nov 15, 2023
vitaut
approved these changes
Nov 15, 2023
|
Thank you |
happymonkey1
pushed a commit
to happymonkey1/fmt
that referenced
this pull request
Apr 7, 2024
* Added macros to disable std::filesystem and std::variant as a workaround for old xcode bugs * Change macro to positive logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older xcode (at least xcode12) had a bug that defined macros for
__cpp_lib_filesystemand__cpp_lib_varianteven if the target did not support it.When building for a target lower than macOS 10.15 with c++17, fmtlib compilation failed. (https://developer.apple.com/xcode/cpp/#c++17)
As a workaround, I would like to add a flag to disable std::filesystem and std::variant.
This problem seems to have been fixed in the latest xcode15, but I don't think version checking is practical.
Similar issues in other projects: ToruNiina/toml11#150