Merge develop -> unmojang, link to wiki page with common authlib-injector servers #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves fn2006#85 Prism Launcher has refactored a lot of their Nix recently. This includes the changes from PrismLauncher/PrismLauncher#1574, but I'm not 100% sure that's what fixed the issue here, it could have been some other change along the way. Signed-off-by: Evan Goode <[email protected]>
Port over recent Nix packaging changes from Prism Launcher
fix Nix wrapper using wrong JAVA_PATHS env var
|
I'm also going to tack on this bugfix to this PR: 4957597. And possibly more to come. |
|
Cool, added the gist to the wiki at https://github.com/fn2006/PollyMC/wiki/Alternative-Auth-Servers |
Signed-off-by: Evan Goode <[email protected]>
Fixes a bug where the wrong account could be marked as "in use" when the game is launched if there are multiple accounts that share the same profile ID. This can lead to the launcher trying to refresh an account that's currently in use by the game, leading to "Invalid session" errors in-game. Signed-off-by: Evan Goode <[email protected]>
|
Ok, fixed the link. Should be ready now. |
fn2006
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a link on the "Add authlib-injector" dialog to a wiki page (not yet created) with a table of common API servers. The dialog now reads
Here is my draft of the wiki page: https://gist.github.com/evan-goode/6f4aafcbb26b0b4223fd650c9fd34675 (GitHub wikis are not in the source tree, so I don't think I can pull request it). I've marked this PR as a draft since the link in the code needs to be updated after the wiki page is created.
This PR also merges recent changes from the develop branch into the unmojang branch.