Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth server column to account list #139

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

BatteredBunny
Copy link

I had a hard time distinguishing accounts with same names in account list so i added an auth server column.

pollymc_account_list

Copy link
Contributor

@evan-goode evan-goode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, could you add

ui->listView->header()->setSectionResizeMode(AccountList::VListColumns::AuthServerColumn, QHeaderView::ResizeToContents);

to launcher/ui/pages/global/AccountListPage.cpp so that the column is auto-resized to fit the URL?

Also, personally I'd prefer the full authlib-injector URL rather than the authserver URL with the authlib-injector suffix stripped out (and blank for Mojang/MSA/Offline accounts). The reason being that if you wanted to add a new account and copy that URL for the new account, you'd need that full "authlib-injector" endpoint (many servers will work anyway because they send the x-authlib-injector-api-location header, but this is not guaranteed). You'd need to add a getter for authlibInjectorUrl in AccountData.h.

@BatteredBunny
Copy link
Author

This is great, could you add

ui->listView->header()->setSectionResizeMode(AccountList::VListColumns::AuthServerColumn, QHeaderView::ResizeToContents);

to launcher/ui/pages/global/AccountListPage.cpp so that the column is auto-resized to fit the URL?

Thank you! Did not know that was an option. Initially i had cut the suffix exactly due to it not fitting in the box.

Also, personally I'd prefer the full authlib-injector URL rather than the authserver URL with the authlib-injector suffix stripped out (and blank for Mojang/MSA/Offline accounts). The reason being that if you wanted to add a new account and copy that URL for the new account, you'd need that full "authlib-injector" endpoint (many servers will work anyway because they send the x-authlib-injector-api-location header, but this is not guaranteed). You'd need to add a getter for authlibInjectorUrl in AccountData.h.

Seems reasonable, will do :)

…hServerUrl, make the column auto-resize

Signed-off-by: BatteredBunny <[email protected]>
Signed-off-by: BatteredBunny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants