Egstern/wake function operations are not implemented #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 18, 2023 11:34
… Wake_field structure to utililize them, and have the Impedance constructor pass them to the Wake_field constructor. Also a test to manipulate them from python.
… Wake_field structure to utililize them, and have the Impedance constructor pass them to the Wake_field constructor. Also a test to manipulate them from python.
…f github.com:fnalacceleratormodeling/synergia2 into egstern/wake-function-operations-are-not-implemented
… cuda so that this PR can pass tests. Merge branch 'devel3' into egstern/wake-function-operations-are-not-implemented
egstern
deleted the
egstern/wake-function-operations-are-not-implemented
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old methods to multiply wakes by factor would not be helpful because the wake functions are wrapped inside the impedance operation object which is buried somewhere inaccessible. Instead, I added multiplication factors for each wake function into the Impedance_options object which is used to create the Wake_function by reading the file. The factors can be applied at that time.