Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent division by zero when calculating y values #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

prevent division by zero when calculating y values #25

wants to merge 1 commit into from

Conversation

glaszig
Copy link

@glaszig glaszig commented Dec 3, 2022 •
edited
Loading

calling getY() with 0 value would produce NaN which are invalid in svg where those end up. in that case, the added condition returns the height in float to draw a data point at y=0.

related #13, closes #24, fixes #14

@glaszig
prevents division by zero when calculating y values
7d0ccf1 
calling getY() with 0 value would produce NaN which are invalid in svg where those end up.
in that case, the added condition returns the height in float to draw a data point at y=0.

releated fnando#13, closes fnando#24, fixes fnando#14
@glaszig
Copy link
Author

glaszig commented Jan 27, 2024

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

potential divide by 0 error in getY() returns NaN Error when data are filled with zeros
1 participant
@glaszig