New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: lazy creating reducer (#24) #33

Open

geekact wants to merge 1 commit into master from lazy-reducer

Member

geekact commented Dec 16, 2022 •

edited

Loading

Fixes #24

github-advanced-security bot found potential problems

View reviewed changes

src/store/modelStore.ts

+                    const { consumer, onComplete } = this.lazyKeys[key]!;
+                    delete this.lazyKeys[key];
+                    this.appendReducer(key, consumer);
+                    this.onInitialized(onComplete);

Check failure

Code scanning / CodeQL

Wrong use of 'this' for static method

Access to instance method [onInitialized](1) from static method [lazyLoad](2) is not possible through `this`.

geekact force-pushed the lazy-reducer branch 2 times, most recently from 9f6d742 to eb608c9 Compare

December 19, 2022 02:45


          feat: lazy creating reducer

afd787a

geekact force-pushed the lazy-reducer branch from eb608c9 to afd787a Compare

December 22, 2022 06:45

geekact mentioned this pull request

foca 2.0 规划 #36

Closed

7 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet