Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODFIN-382 - Add dry-run mode for bulk FY finance updates #496

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

azizbekxm
Copy link
Contributor

https://folio-org.atlassian.net/browse/MODFIN-382

Purpose

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Examples exist for all schemas
    • Descriptions exist for all schema properties
    • All schemas pass raml-cop linting
  • Does this introduce breaking changes?
    • Were there any schema changes?
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@azizbekxm azizbekxm requested a review from a team December 20, 2024 08:40
@azizbekxm azizbekxm merged commit 38ee053 into master Dec 20, 2024
3 checks passed
@azizbekxm azizbekxm deleted the MODFIN-382 branch December 20, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants