Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODFQMMGR-378 Update approach to enabling ECS for an entity type #64

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

mweaver-ebsco
Copy link
Contributor

This commit adds a new boolean crossTenantQueriesEnabled property to entity types, to control when an entity type supports cross-query queries. It also changes the shape of the entity type column "source" property's object model, adding a new "type" property. This new property will allow us to use the "source" to define value sources that come from things besides entity types. There's also a new "name" property, which is for setting the name of the value provider within the source type

Purpose

Describe the purpose of the pull request. Include background information if necessary.

Approach

How does this change fulfill the purpose?

TODOS and Open Questions

  • Use GitHub checklists. When solved, check the box and explain the answer.

Learning

Describe the research stage. Add links to blog posts, patterns, libraries or addons used to solve this problem.

This commit adds a new boolean crossTenantQueriesEnabled property to
entity types, to control when an entity type supports cross-query
queries. It also changes the shape of the entity type column "source"
property's object model, adding a new "type" property. This new property
will allow us to use the "source" to define value sources that come from
things besides entity types. There's also a new "name" property, which
is for setting the name of the value provider within the source type
"fqm"
]
},
"name": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of this name, but I can't think of anything better

Copy link

sonarqubecloud bot commented Aug 9, 2024

@mweaver-ebsco mweaver-ebsco merged commit adadbbb into master Aug 9, 2024
8 checks passed
@mweaver-ebsco mweaver-ebsco deleted the MODFQMMGR-378-ecs-enabled branch August 9, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants