-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MODLISTS-129] Move migration request/response types from mod-fqm-manager #68
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
src/main/resources/swagger.api/schemas/fqmMigrateRequest.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
{ | ||
"$schema": "https://json-schema.org/draft/2020-12/schema", | ||
"title": "Entity Upgrade Request", | ||
"description": "Schema for a request to upgrade an entity payload, including an entity type ID, FQL query, and list of fields.", | ||
"type": "object", | ||
"properties": { | ||
"entityTypeId": { | ||
"description": "ID of the entity type to be upgraded", | ||
"type": "string", | ||
"format": "UUID" | ||
}, | ||
"fqlQuery": { | ||
"description": "FQL query string to be upgraded", | ||
"type": "string" | ||
}, | ||
"fields": { | ||
"description": "List of fields to be upgraded", | ||
"type": "array", | ||
"items": { | ||
"type": "string" | ||
} | ||
} | ||
}, | ||
"additionalProperties": false, | ||
"required": ["entityTypeId"] | ||
} |
33 changes: 33 additions & 0 deletions
33
src/main/resources/swagger.api/schemas/fqmMigrateResponse.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
{ | ||
"$schema": "https://json-schema.org/draft/2020-12/schema", | ||
"title": "Entity Upgrade Response", | ||
"description": "Schema for a migrated query, with associated entity type, fields, and potential warnings", | ||
"type": "object", | ||
"properties": { | ||
"entityTypeId": { | ||
"description": "ID of the post-upgrade entity type", | ||
"type": "string", | ||
"format": "uuid" | ||
}, | ||
"fqlQuery": { | ||
"description": "Post-upgrade FQL query string", | ||
"type": "string" | ||
}, | ||
"fields": { | ||
"description": "Post-upgrade list of fields", | ||
"type": "array", | ||
"items": { | ||
"type": "string" | ||
} | ||
}, | ||
"warnings": { | ||
"description": "List of warnings issued during the upgrade", | ||
"type": "array", | ||
"items": { | ||
"$ref": "./fqmMigrateWarning.json" | ||
} | ||
} | ||
}, | ||
"additionalProperties": false, | ||
"required": ["entityTypeId"] | ||
} |
18 changes: 18 additions & 0 deletions
18
src/main/resources/swagger.api/schemas/fqmMigrateWarning.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
{ | ||
"$schema": "https://json-schema.org/draft/2020-12/schema", | ||
"title": "Entity Upgrade Warning", | ||
"description": "Warnings resulting from a query upgrade", | ||
"type": "object", | ||
"properties": { | ||
"description": { | ||
"description": "Description of the warning", | ||
"type": "string" | ||
}, | ||
"type": { | ||
"description": "Type of warning", | ||
"type": "string" | ||
} | ||
}, | ||
"additionalProperties": false, | ||
"required": ["description", "type"] | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the wording here with "load-bearing" commas :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm glad there's something to love in that situation, lol