[MODAUD-174] - Consume piece change events and implement endpoints #155

azizbekxm · 2023-11-09T11:33:22Z

Purpose

https://issues.folio.org/browse/MODAUD-174

Approach

Implemented functionality for extracting the status change history for a Piece

Created table to store audit log for pieces
Imlemented consumer verticle and event handler
Provided services and DAOs
Implemented GET endpoint to retrieve by id: /audit-data/acquisition/piece/{id}
Implemented GET endpoint to retrieve by id only unique status changes: /audit-data/acquisition/piece/{id}/unique-status

mod-audit-server/src/main/java/org/folio/rest/impl/AuditDataAcquisitionImpl.java

...it-server/src/main/java/org/folio/services/acquisition/impl/PieceAuditEventsServiceImpl.java

mod-audit-server/src/main/resources/templates/db_scripts/schema.json

descriptors/ModuleDescriptor-template.json

…code

imerabishvili · 2023-11-15T11:56:23Z

.gitignore

Doubt
Do we need to push this?

it avoid situation where intellij idea asks whether add postgres-conf.json to git or not. For me it is useful

mod-audit-server/src/main/java/org/folio/util/DbUtils.java

mod-audit-server/src/main/java/org/folio/rest/impl/AuditDataAcquisitionImpl.java

...it-server/src/main/java/org/folio/services/acquisition/impl/OrderAuditEventsServiceImpl.java

… error level in catch block

SerhiiNosko · 2023-11-15T13:49:07Z

mod-audit-server/src/main/java/org/folio/dao/acquisition/impl/OrderEventsDaoImpl.java

-        LocalDateTime.ofInstant(orderAuditEvent.getEventDate().toInstant(), ZoneOffset.UTC),
-        LocalDateTime.ofInstant(orderAuditEvent.getActionDate().toInstant(), ZoneOffset.UTC),
+        LocalDateTime.ofInstant(orderAuditEvent.getEventDate().toInstant(), ZoneId.systemDefault()),
+        LocalDateTime.ofInstant(orderAuditEvent.getActionDate().toInstant(), ZoneId.systemDefault()),


Just for may knowledge why we need to change ZoneOffset here?

1- orderAuditEvent.getActionDate().toInstant() this part converting date to second
2- LocalDateTime.ofInstant(orderAuditEvent.getActionDate().toInstant(), ZoneId.systemDefault()) localdatetime creating date time from second based on system zoneId

mod-audit-server/src/main/java/org/folio/dao/acquisition/impl/PieceEventsDaoImpl.java

mod-audit-server/src/main/java/org/folio/rest/impl/AuditDataAcquisitionImpl.java

sonarqubecloud · 2023-11-15T14:16:38Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
9 Code Smells

91.8% Coverage
0.0% Duplication

[MODAUD-174] - Consume piece change events and implement endpoints

854e82a

azizbekxm marked this pull request as draft November 9, 2023 11:33

azizbekxm added 13 commits November 9, 2023 16:47

[MODAUD-174] - Fixed unit tests

3a35fb9

[MODAUD-174] - Fixed Code smell

dbaaf9f

[MODAUD-174] - Fixed Code smell

38c6613

[MODAUD-174] - Fixed Unit tests

11961c6

[MODAUD-174] - Minor improvements

066fbac

[MODAUD-174] - Implements kafka handler and creating table

536e9ea

[MODAUD-174] - Increased code coverage

97e24a2

[MODAUD-174] - Increased code coverage

0d3017b

[MODAUD-174] - Minor improvements

3262ab6

[MODAUD-174] - Minor improvements

42fbbad

[MODAUD-174] - Minor improvements

a2d8ae2

[MODAUD-174] - Minor improvements

7516c51

[MODAUD-174] - Minor improvements

90c5205

SerhiiNosko reviewed Nov 13, 2023

View reviewed changes

mod-audit-server/src/main/java/org/folio/rest/impl/AuditDataAcquisitionImpl.java Outdated Show resolved Hide resolved

SerhiiNosko reviewed Nov 13, 2023

View reviewed changes

...it-server/src/main/java/org/folio/services/acquisition/impl/PieceAuditEventsServiceImpl.java Outdated Show resolved Hide resolved

[MODAUD-174] - Minor improvements

9a12aac

SerhiiNosko reviewed Nov 13, 2023

View reviewed changes

mod-audit-server/src/main/resources/templates/db_scripts/schema.json Outdated Show resolved Hide resolved

[MODAUD-174] - Implemented uniq-status api

20a1b7f

SerhiiNosko reviewed Nov 13, 2023

View reviewed changes

descriptors/ModuleDescriptor-template.json Outdated Show resolved Hide resolved

azizbekxm added 9 commits November 14, 2023 18:28

[MODAUD-174] - Implemented status change history feature and cleaned …

ecd4f24

…code

[MODAUD-174] - Implemented status change history feature and cleaned …

3811d8a

…code

[MODAUD-174] - Implemented status change history feature and cleaned …

1646698

…code

[MODAUD-174] - draft changes

df807cc

[MODAUD-174] - Fixed error

aa96b19

[MODAUD-174] - minor improvements

821a46a

[MODAUD-174] - minor improvements

d43d0ee

[MODAUD-174] - minor improvements

d32bc03

[MODAUD-174] - minor improvements

6aef666

azizbekxm added 4 commits November 15, 2023 16:14

[MODAUD-174] - Fixed unit tests

f7e9581

[MODAUD-174] - Fixed unit tests

19d7e9f

[MODAUD-174] - Fixed sql query

c72b7b8

[MODAUD-174] - Extracted duplicate methods

6438c25

azizbekxm marked this pull request as ready for review November 15, 2023 11:47

azizbekxm requested a review from a team November 15, 2023 11:48

[MODAUD-174] - Added java docs

49b39b2

imerabishvili reviewed Nov 15, 2023

View reviewed changes

[MODAUD-174] - Improved java integration test

d04fa1f

SerhiiNosko requested a review from gurleenkaurbp November 15, 2023 12:11

azizbekxm added 2 commits November 15, 2023 17:14

[MODAUD-174] - Extracted handleFauilures and optimized codebase

3132186

[MODAUD-174] - Fixed sql query

f8c661e

SerhiiNosko reviewed Nov 15, 2023

View reviewed changes

mod-audit-server/src/main/java/org/folio/util/DbUtils.java Show resolved Hide resolved

azizbekxm added 2 commits November 15, 2023 17:28

[MODAUD-174] - Fixed sql query

82b48db

[MODAUD-174] - Minor improvement

af27863

SerhiiNosko reviewed Nov 15, 2023

View reviewed changes

mod-audit-server/src/main/java/org/folio/rest/impl/AuditDataAcquisitionImpl.java Show resolved Hide resolved

SerhiiNosko reviewed Nov 15, 2023

View reviewed changes

...it-server/src/main/java/org/folio/services/acquisition/impl/OrderAuditEventsServiceImpl.java Outdated Show resolved Hide resolved

azizbekxm added 4 commits November 15, 2023 17:39

[MODAUD-174] - Improved AuditDataAcquisitionImpl

ec50fb3

[MODAUD-174] - Improved AuditDataAcquisitionImpl and changed debug to…

26bcef4

… error level in catch block

[MODAUD-174] - Fixed ZoneOffset

1f00735

[MODAUD-174] - Improved log.error message

fda19eb

SerhiiNosko reviewed Nov 15, 2023

View reviewed changes

mod-audit-server/src/main/java/org/folio/dao/acquisition/impl/PieceEventsDaoImpl.java Outdated Show resolved Hide resolved

SerhiiNosko reviewed Nov 15, 2023

View reviewed changes

mod-audit-server/src/main/java/org/folio/rest/impl/AuditDataAcquisitionImpl.java Outdated Show resolved Hide resolved

[MODAUD-174] - Minor improvements

3881bdc

SerhiiNosko approved these changes Nov 15, 2023

View reviewed changes

Abdulkhakimov approved these changes Nov 16, 2023

View reviewed changes

azizbekxm merged commit fb5889a into master Nov 16, 2023
3 checks passed

azizbekxm deleted the MODAUD-174 branch November 16, 2023 09:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MODAUD-174] - Consume piece change events and implement endpoints #155

[MODAUD-174] - Consume piece change events and implement endpoints #155

azizbekxm commented Nov 9, 2023

imerabishvili Nov 15, 2023

azizbekxm Nov 15, 2023 •

edited

Loading

SerhiiNosko Nov 15, 2023

azizbekxm Nov 15, 2023 •

edited

Loading

sonarqubecloud bot commented Nov 15, 2023

[MODAUD-174] - Consume piece change events and implement endpoints #155

[MODAUD-174] - Consume piece change events and implement endpoints #155

Conversation

azizbekxm commented Nov 9, 2023

Purpose

Approach

imerabishvili Nov 15, 2023

Choose a reason for hiding this comment

azizbekxm Nov 15, 2023 • edited Loading

Choose a reason for hiding this comment

SerhiiNosko Nov 15, 2023

Choose a reason for hiding this comment

azizbekxm Nov 15, 2023 • edited Loading

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 15, 2023

azizbekxm Nov 15, 2023 •

edited

Loading

azizbekxm Nov 15, 2023 •

edited

Loading