Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODBULKOPS-179 - Rendering Instance record data in bulk edit forms and files #155

Merged
merged 4 commits into from
Dec 28, 2023

Conversation

siarhei-charniak
Copy link
Contributor

@siarhei-charniak siarhei-charniak commented Dec 27, 2023

MODBULKOPS-179 - Rendering Instance record data in bulk edit forms and files

Purpose

Provide consistent display of instance data in all bulk edit forms (Matching records, Are you sure and Confirmation) and files that user can download to preview the records.

Approach

  • Implemented model
  • Updated unit tests

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • Were any API paths or methods changed, added or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added, or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@siarhei-charniak siarhei-charniak requested a review from a team December 27, 2023 12:16
@siarhei-charniak siarhei-charniak self-assigned this Dec 27, 2023
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
93.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

bean = new HoldingsRecord().withVersion(2);
} else {
bean = new Instance();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to add additional verification and throw UnsupportedOperationException if bean class is not appropriate.

@siarhei-charniak siarhei-charniak merged commit 687c14f into master Dec 28, 2023
6 checks passed
@siarhei-charniak siarhei-charniak deleted the MODBULKOPS-179 branch December 28, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants