[CIRC-1932] Implement search-slips endpoint skeleton #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import io.vertx.ext.web.RoutingContext; | ||
|
|
||
| public class SearchSlipsResource extends SlipsResource { | ||
| private static final String SEARCH_SLIPS_KEY = "searchSlips"; |
There was a problem hiding this comment.
This collection name can be an instance variable injected via constructor
ramls/pick-slips.raml
Outdated
| version: v0.3 | ||
| protocols: [ HTTP, HTTPS ] | ||
| baseUri: http://localhost:9130 | ||
|
|
||
| documentation: | ||
| - title: API for fetching current pick slips | ||
| content: <b>API for pick slips generation</b> | ||
| - title: API for fetching current pick and search slips |
There was a problem hiding this comment.
Collectively they are called "staff slips"
| import io.vertx.core.json.JsonObject; | ||
|
|
||
| class SearchSlipsTests extends APITests { | ||
| private static final String TOTAL_RECORDS = "totalRecords"; |
There was a problem hiding this comment.
Suggested change
| private static final String TOTAL_RECORDS = "totalRecords"; | |
| private static final String TOTAL_RECORDS_KEY = "totalRecords"; |
OleksandrVidinieiev
approved these changes
Oct 31, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Create a new (dummy) endpoint:
GET /circulation/search-slips/{servicePointId} that should return an empty result:
{
"searchSlips" : [ ],
"totalRecords" : 0
}
Resolves: CIRC-1932
Approach