CIRC-2100 Fetch print details while fetching request details based on cql query #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tched by CQL query
…RC-2100 # Conflicts: # src/main/java/org/folio/circulation/infrastructure/storage/PrintEventsRepository.java # src/main/java/org/folio/circulation/support/Clients.java # src/test/java/api/printEvents/PrintEventsTests.java # src/test/java/api/support/fakes/FakeOkapi.java
Vignesh-kalyanasundaram
changed the title
Vignesh-kalyanasundaram
requested review from
alexanderkurash,
gurleenkaurbp,
OleksandrVidinieiev,
kapil-epam and
SreejaMangarapu
src/main/java/org/folio/circulation/infrastructure/storage/PrintEventsRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/circulation/infrastructure/storage/PrintEventsRepository.java
Show resolved
Hide resolved
|
gurleenkaurbp
approved these changes
Aug 2, 2024
SreejaMangarapu
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of the PR is to implement CIRC-2100
Approach
In request app, when any of the filter is selected, circulation/request API is called. In order to show the print information of a request, we have introduced a new object(printEventDetail) in Request entity.
If the printEventFeature is enabled for a tenant, we are making a call to /print-events-storage/print-events-status with list of requestIds. Once the print events are retrieved, we are mapping those details to corresponding request object. when we are fetching the userDetails of requester and proxy user, we also include the requesterId of printEvent object and map it to the user object of printEventDetail so that we will return updated data.
If the printEventFeature is disabled or if the settings is not found for a tenant, current code will work as it is.
TODOS and Open Questions
Learning