CIRC-2198 Implement the code for the feature UXPROD-5001 #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logic to store flag into database
AntonAntonich
changed the title
src/main/java/org/folio/circulation/resources/RequestNoticeSender.java
Outdated
Show resolved
Hide resolved
gurleenkaurbp
approved these changes
Dec 16, 2024
OleksandrVidinieiev
approved these changes
Dec 16, 2024
| @@ -427,6 +428,10 @@ public boolean hasLoan() { | |||
| return loan != null; | |||
| } | |||
|
|
|||
| public boolean getDcbReRequestCancellationValue() { | |||
There was a problem hiding this comment.
Suggested change
| public boolean getDcbReRequestCancellationValue() { | |
| public boolean isDcbReRequestCancellation() { |
| sendCancellationNoticeForRequestWithItemId(request); | ||
| } else { | ||
| sendCancellationNoticeForRequestWithoutItemId(request); | ||
| // Send the cancellation notice only if the isDcbReRequestCancellation flag is false |
There was a problem hiding this comment.
Do we really need this comment? I think code below speaks for itself
There was a problem hiding this comment.
will remove it
Comment on lines
33
to
34
| Mockito.verify(immediatePatronNoticeService, times(0)).acceptNoticeEvent(any()); | ||
| Mockito.verify(immediatePatronNoticeService, times(0)).sendNotice(any(), any()); |
There was a problem hiding this comment.
Suggested change
| Mockito.verify(immediatePatronNoticeService, times(0)).acceptNoticeEvent(any()); | |
| Mockito.verify(immediatePatronNoticeService, times(0)).sendNotice(any(), any()); | |
| Mockito.verify(immediatePatronNoticeService, times(0)).acceptNoticeEvent(any()); | |
| Mockito.verify(immediatePatronNoticeService, times(0)).sendNotice(any(), any()); |
|
gurleenkaurbp
pushed a commit
that referenced
this pull request
Jan 17, 2025
CIRC-2198 Implement the code for the feature UXPROD-5001
gurleenkaurbp
added a commit
that referenced
this pull request
Jan 17, 2025
* CIRC-2198 Implement the code for the feature UXPROD-5001 (#1521) CIRC-2198 Implement the code for the feature UXPROD-5001 * Update NEWS.md * [maven-release-plugin] prepare release v24.3.9 * [maven-release-plugin] prepare for next development iteration --------- Co-authored-by: Antony Hruschev <[email protected]> Co-authored-by: Antony_Hruschev <[email protected]>
gurleenkaurbp
added a commit
that referenced
this pull request
Jan 17, 2025
* release branch * Release 24.3.1 (#1517) * CIRC-2168 Patron notices for the trigger “Item recalled” not sent if the item is not 1st in the title request queue (#1512) * CIRC-2168 Fix patron notice issue * CIRC-2168 Fix patron notice issue * CIRC-2168 Adding test case for the new scenario * CIRC-2168 Fix sonar issues * Fixing test case error * Update NEWS * [maven-release-plugin] prepare release v24.3.1 * [maven-release-plugin] prepare for next development iteration * Update NEWS * [maven-release-plugin] prepare release v24.3.2 * [maven-release-plugin] prepare for next development iteration * CIRC-2182 Intermediate request support (#1520) * CIRC-2182 Add support for intermediate request * CIRC-2182 Add missing permissions * CIRC-2182 Add missing permissions * CIRC-2182 Add missing permissions * CIRC-2182 Refactoring and logging * CIRC-2182 Extend test (cherry picked from commit 7d6bfe8) * [CIRC-2199] Avoid self-invocation for request rules while moving requests (#1522) * [EUREKA-430] Avoid self-invocation for request rules while moving requests * [EUREKA-430] Remove unnecessary new constructor * [EUREKA-430] Add unit tests * [EUREKA-430] Improve tests (cherry picked from commit 4414f1d) * Update NEWS * [maven-release-plugin] prepare release v24.3.3 * [maven-release-plugin] prepare for next development iteration * CIRC-2205 Remove redundant permission set declarations (cherry picked from commit 6b91a09) * Update NEWS * [maven-release-plugin] prepare release v24.3.4 * [maven-release-plugin] prepare for next development iteration * CIRC-2197 Fix search slips for requests queue (#1526) * CIRC-2197 Fix search slips for requests queue * CIRC-2197 fix code smells (cherry picked from commit 6654963) * Update NEWS * [maven-release-plugin] prepare release v24.3.5 * [maven-release-plugin] prepare for next development iteration * CIRC-2219 rename incorrect permissions (#1531) (cherry picked from commit 297dbe6) * Update NEWS * [maven-release-plugin] prepare release v24.3.6 * [maven-release-plugin] prepare for next development iteration * To release 24.3.7 (#1535) * CIRC-2177: Filter request by Retrieval Service Point (#1518) * CIRC-2177: populating request.item new fields before request update and create * CIRC-2177: populating request.item new fields for request get API's * CIRC-2177: added debugging log * CIRC-2177: setting SP and location from requestRepresentation * CIRC-2177: unit test case implementation * CIRC-2177: fix unit test issue * CIRC-2177: fix unit test issue * CIRC-2177: added check for location and SP in StoredRequestRepresentation * CIRC-2177: upgraded request-storage interface version from 6.1 to 6.2 * Update NEWS.md file * [maven-release-plugin] prepare release v24.3.7 * [maven-release-plugin] prepare for next development iteration * CIRC-2197 add limit to requests fetching query (cherry picked from commit 2b857d9) * Update NEWS * [maven-release-plugin] prepare release v24.3.8 * [maven-release-plugin] prepare for next development iteration * CIRC-2198 Implement the code for the feature UXPROD-5001 (#1521) CIRC-2198 Implement the code for the feature UXPROD-5001 * Update NEWS.md * [maven-release-plugin] prepare release v24.3.9 * [maven-release-plugin] prepare for next development iteration --------- Co-authored-by: MagzhanArtykov <[email protected]> Co-authored-by: Vignesh <[email protected]> Co-authored-by: Roman_Barannyk <[email protected]> Co-authored-by: Roman Barannyk <[email protected]> Co-authored-by: OleksandrVidinieiev <[email protected]> Co-authored-by: Saba-Zedginidze-EPAM <[email protected]> Co-authored-by: Oleksandr Vidinieiev <[email protected]> Co-authored-by: Kapil Verma <[email protected]> Co-authored-by: Antony Hruschev <[email protected]> Co-authored-by: Antony_Hruschev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Implement the code for the feature UXPROD-5001
Jira
CIRC-2198