CIRC-2210: Remove excessive INFO logging of rules in ExecutableRules #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leRules https://folio-org.atlassian.net/browse/CIRC-2210 ExecutableRules.determinePolicy runs ``` log.info("Executing circulation rules: `{}` with parameters: `{}` to determine {}", text, parameters, policyType); ``` which prints the text variable that contains the circulation rules file that may contain hundres of lines. This is printed whenever circulation rules are applied, this is very often. This bloats the log. This is not needed at INFO level. And the log.info it is not needed at DEBUG level because the calling methods in ExecutableRules already log parameters and policyType, and CirculationRulesCache already logs the the rules when needed: ``` log.info ("getRulesFromCache:: cache hit for tenant {}", tenantId); log.debug("getRulesFromCache:: cached rules: {}", cachedRules::getRulesAsText); ``` Task: Delete log.info in ExecutableRules.determinePolicy.
|
julianladisch
requested review from
steveellis,
barbaraloehle and
dennisbenndorf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/CIRC-2210
Purpose
ExecutableRules.determinePolicy runs
which prints the text variable that contains the circulation rules file that may contain hundres of lines.
This is printed whenever circulation rules are applied, this is very often.
This bloats the log.
This is not needed at INFO level.
And the log.info it is not needed at DEBUG level because the calling methods in ExecutableRules already log parameters and policyType, and CirculationRulesCache already logs the the rules when needed:
Approach
Delete log.info in ExecutableRules.determinePolicy.
TODOS and Open Questions
Learning
Avoid multi-line logging on INFO level.
Avoid duplicate logging.