Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MODEXPW-529] Create CSV file for claims #609

Merged
merged 19 commits into from
Dec 19, 2024
Merged

[MODEXPW-529] Create CSV file for claims #609

merged 19 commits into from
Dec 19, 2024

Conversation

Saba-Zedginidze-EPAM
Copy link
Contributor

@Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM commented Dec 13, 2024 •
edited
Loading

Purpose

[MODEXPW-529] Create CSV file for claims

Approach

  • Organize mappers and converters properly in main module
  • Add general csv converter to work with different entities
  • Add new mapper to generate csv files for claims
  • Put acq tests in appropriate packages
  • Convert simple tests to normal unit tests and remove integration test startups unnecessarily
  • Add new tests to verify csv file generation
  • Simplify existing tests regarding acq exports

Learning

Refer to RFC-4180 for proper CSV specifications

@Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM changed the title Modexpw 529 [MODEXPW-529] Create CSV file for claims Dec 13, 2024
@BKadirkhodjaev BKadirkhodjaev requested a review from a team December 17, 2024 12:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM requested a review from a team December 17, 2024 16:00
@Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM merged commit 882cc76 into master Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SerhiiNosko SerhiiNosko SerhiiNosko approved these changes

@BKadirkhodjaev BKadirkhodjaev BKadirkhodjaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Saba-Zedginidze-EPAM @SerhiiNosko @BKadirkhodjaev