-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UXPROD-5090 Update DCB service point values for the attribute Hold shelf expiration period #142
Conversation
@@ -22,6 +22,7 @@ public class TransactionApiController implements TransactionsApi { | |||
|
|||
private final TransactionsService transactionsService; | |||
private final TransactionAuditService transactionAuditService; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls remove this extra line
@@ -3,11 +3,13 @@ | |||
import java.util.UUID; | |||
import lombok.RequiredArgsConstructor; | |||
import lombok.extern.log4j.Log4j2; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls remove extra line
@@ -0,0 +1,22 @@ | |||
package org.folio.dcb.domain.converter; | |||
|
|||
import static org.junit.jupiter.api.Assertions.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls avoid wild cards import
@AntonAntonich - please include instructions in the readme.md file regarding "If adjustments are necessary, they can be made by the FSE team through database scripts." It's important to note that this table will contain only one row, and if no row is present, the default value will be 10 days. Changes to this table will only affect newly created virtual service points and virtual service points that are reused during the creation of a new DCB transaction. Existing virtual service points will not automatically update when changes are made to the hold-shelf-expiration value in the database. Additionally, the DCB service point originally created when this module was enabled for a tenant will not be altered if the hold shelf expiration value is dynamically updated in the table. |
|
UXPROD-5090