Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(api-docs): Fix documentation generation github workflow #369

Merged
merged 1 commit into from
Jan 29, 2025
Merged

docs(api-docs): Fix documentation generation github workflow #369

merged 1 commit into from
Jan 29, 2025

Conversation

viacheslavkol
Copy link
Contributor

@viacheslavkol viacheslavkol commented Jan 29, 2025 •
edited
Loading

Purpose

Fix documentation generation github workflow

Approach

  • Fix generated filename
  • Fix filepath for release builds

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

MODELINKS-291

@viacheslavkol
docs(api-docs): Fix documentation generation github workflow
cc212dd 
- Fix generated filename
- Fix filepath for release builds

Closes: MODELINKS-291
@viacheslavkol viacheslavkol self-assigned this Jan 29, 2025
@viacheslavkol viacheslavkol requested a review from a team as a code owner January 29, 2025 12:43
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@viacheslavkol viacheslavkol merged commit fc48b2f into master Jan 29, 2025
5 checks passed
@viacheslavkol viacheslavkol deleted the MODELINKS-291 branch January 29, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukhiddin-yusuf mukhiddin-yusuf mukhiddin-yusuf approved these changes

@psmagin psmagin psmagin approved these changes

@SvitlanaKovalova1 SvitlanaKovalova1 Awaiting requested review from SvitlanaKovalova1 SvitlanaKovalova1 is a code owner automatically assigned from folio-org/spitfire-backend

Assignees

@viacheslavkol viacheslavkol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viacheslavkol @psmagin @mukhiddin-yusuf