[MODFIN-391]. Minimize amount of requests to retrieve transactions for ledger #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BKadirkhodjaev
changed the title
azizbekxm
reviewed
Jan 8, 2025
|
|
||
| private List<TransactionTotal> filterFundIdsByAllocationDirection(List<String> fundIds, List<TransactionTotal> transactions, String direction) { | ||
| // Note that here getToFundId() is used when direction is from (a negation is used afterward) | ||
| Function<TransactionTotal, String> getFundId = "from".equals(direction) ? TransactionTotal::getToFundId : TransactionTotal::getFromFundId; |
There was a problem hiding this comment.
I assume it should be
"from".equals(direction) ? TransactionTotal::getFromFundId : TransactionTotal::getToFundId;
There was a problem hiding this comment.
I assume it should be
"from".equals(direction) ? TransactionTotal::getFromFundId : TransactionTotal::getToFundId;
I think it was intentional like this, this code is taken from TransactionService
azizbekxm
reviewed
Jan 8, 2025
| String fundIdField = "from".equals(direction) ? "fromFundId" : "toFundId"; | ||
| String fundQuery = convertIdsToCqlQuery(fundIds, fundIdField, "==", " OR "); | ||
| List<String> trTypeValues = trTypes.stream().map(TransactionTotal.TransactionType::value).toList(); | ||
| String trTypeQuery = convertIdsToCqlQuery(trTypeValues, "transactionType", "==", " OR "); |
There was a problem hiding this comment.
from method name we are incorrectly using this by setting type value, better to use other method or create new one which take value and fieldName only
azizbekxm
reviewed
Jan 8, 2025
|
|
||
| public Future<List<TransactionTotal>> getTransactionsToFunds(List<String> fundIds, String fiscalYearId, | ||
| List<TransactionTotal.TransactionType> trTypes, RequestContext requestContext) { | ||
| return getTransactionsFromOrToFunds(fundIds, fiscalYearId, trTypes, "to", requestContext); |
There was a problem hiding this comment.
I suggest to use string variable instead as static or enum variable
src/main/java/org/folio/services/transactions/TransactionTotalService.java
Outdated
Show resolved
Hide resolved
|
azizbekxm
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Approach