MODINV-1023: Fix mod-inventory OOM issue. #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto MODINV-1023 # Conflicts: # NEWS.md
VRohach
requested review from
Aliaksandr-Fedasiuk,
KaterynaSenchenko,
RuslanLavrov,
okolawole-ebsco,
JavokhirAbdullayev,
RomanChernetskyi,
Maksat-Galymzhan and
dmytrokrutii
src/main/java/org/folio/inventory/dataimport/cache/MappingMetadataCache.java
Outdated
Show resolved
Hide resolved
| @@ -107,4 +111,18 @@ private CompletableFuture<Optional<MappingMetadataDto>> loadMappingMetadata(Stri | |||
| }); | |||
| } | |||
|
|
|||
| public static synchronized MappingMetadataCache getInstance(Vertx vertx, HttpClient httpClient, JsonObject config) { | |||
There was a problem hiding this comment.
I think you should get the config from the Vertx instance and remove the config parameter here.
There was a problem hiding this comment.
@okolawole-ebsco Thank you! I improved it. Feel free to double-check it.
okolawole-ebsco
approved these changes
May 28, 2024
KaterynaSenchenko
approved these changes
Jun 5, 2024
Maksat-Galymzhan
approved these changes
Jun 5, 2024
JavokhirAbdullayev
approved these changes
Jun 5, 2024
…nto MODINV-1023 # Conflicts: # NEWS.md
Aliaksandr-Fedasiuk
approved these changes
Jun 5, 2024
…nto MODINV-1023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change creation MappingMetadataCache: 1 Instance for all verticles.