Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MODINV-1031] Implement endpoint to update ownership of Holdings #731

Merged
merged 14 commits into from
Jun 25, 2024

Conversation

RomanChernetskyi
Copy link
Contributor

@RomanChernetskyi RomanChernetskyi commented Jun 13, 2024

Purpose

Implement endpoint to update ownership of Holdings

Approach

  • Validate DTO
  • Verify that the Instance is shared (check that source has prefix CONSORTIUM) before sending requests to the target tenant
  • Save holdings on target
  • Save Items
  • Delete Items on source
  • Delete Holdings on source

Copy link

}

private CompletableFuture<List<Item>> createItems(List<JsonObject> jsons, List<NotUpdatedEntity> notUpdatedEntities, ItemCollection itemCollection) {
List<Item> itemRecordsToUpdateOwnership = jsons.stream()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In many methods, there are not enough logs.

@KaterynaSenchenko KaterynaSenchenko merged commit 40ece08 into master Jun 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants